fix: load config defaults if not specified in existing config #1544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
📦 🌐 tendermint v2
github-actions
bot
added
the
📦 ⛰️ gno.land
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #1544 +/- ##
==========================================
- Coverage 55.95% 55.92% -0.04%
==========================================
Files 435 435
Lines 66306 66612 +306
==========================================
+ Hits 37101 37252 +151
- Misses 26303 26460 +157
+ Partials 2902 2900 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
deelawn
reviewed
Jan 17, 2024
deelawn
reviewed
Jan 18, 2024
ajnavarro
approved these changes
Jan 18, 2024
thehowl
reviewed
Jan 18, 2024
ajnavarro
approved these changes
Jan 22, 2024
thehowl
approved these changes
Jan 22, 2024
zivkovicmilos
added
breaking change
leohhhn
pushed a commit
to leohhhn/gno
that referenced
this pull request
Jan 31, 2024
…nolang#1544) ## Description This PR fixes the flow of loading Gno configuration files. Previously, configuration files were loaded without applying default values, causing to funky behavior. Additionally, this PR drops the config TOML template, instead relying on the TOML package itself to marshal. Issue spotted in gnolang#1238 Note: I've tried to keep the original functionality of `LoadOrMakeConfigWithOptions`, because if this is changed or broken up in its current state, things start breaking across dimensions. Funky behavior that's fixed: The `EventStore` fields were not being saved in the original config (since we utilized a template for it, and this was not present in the template). Now, config files should properly save on disk the event store configuration. <details><summary>Contributors' checklist...</summary> - [x] Added new tests, or not needed, or not feasible - [x] Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory - [x] Updated the official documentation or not needed - [x] No breaking changes were made, or a `BREAKING CHANGE: xxx` message was included in the description - [x] Added references to related issues and PRs - [ ] Provided any useful hints for running manual tests - [ ] Added new benchmarks to [generated graphs](https://gnoland.github.io/benchmarks), if any. More info [here](https://github.com/gnolang/gno/blob/master/.benchmarks/README.md). </details>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the flow of loading Gno configuration files.
Previously, configuration files were loaded without applying default values, causing to funky behavior.
Additionally, this PR drops the config TOML template, instead relying on the TOML package itself to marshal.
Issue spotted in #1238
Note:
I've tried to keep the original functionality of
LoadOrMakeConfigWithOptions, because if this is changed or broken up in its current state, things start breaking across dimensions.Funky behavior that's fixed:
The
EventStorefields were not being saved in the original config (since we utilized a template for it, and this was not present in the template). Now, config files should properly save on disk the event store configuration.Contributors' checklist...
BREAKING CHANGE: xxxmessage was included in the description